Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: reserve memory for prim children #189

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

perf: reserve memory for prim children #189

wants to merge 2 commits into from
+3 −0

Conversation

sssooonnnggg
Copy link
Contributor

Optimize the performance of constructing prims, avoiding too frequent reallocation of the children vector.

@syoyo
Copy link
Collaborator

syoyo commented Aug 23, 2024

How much the performance will be improved with this PR?

@sssooonnnggg
Copy link
Contributor Author

sssooonnnggg commented Aug 26, 2024 •
edited
Loading

I used tusdcat to profile a release build using the Visual Studio built-in profiler.
Without this optimization:
image
With this optimization:
image

CPU usage by USDCReader::Impl::ReconstructPrimRecursively decreased rom 51% to 36%.

usdc file for testing:
USDExportedPkg.resources.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sssooonnnggg @syoyo